search

Conky-for-macOS / conky-for-macOS

macOS port of the Light-weight system monitor for X.
https://github.com/Conky-for-macOS/conky-for-macOS/wiki
GNU General Public License v3.0
152 stars 9 forks source link

Updated default conky config to monitor Mac Networking #36

Closed TheFatDemon closed 6 years ago

TheFatDemon commented 6 years ago

Kinda just bugged me that the default didn't work on mac

npyl commented 6 years ago

Hi @TheFatDemon ! Thanks for the PR.

In order to implement this functionality (and still be able to merge with upstream) I think the best approach is to use no interface name: Up:$color ${upspeed} ${color grey} - Down:$color ${downspeed}

This will tell conky to choose the default interface name (which on linux is eth0 and on mac en0, on bsd .... and so on)

Problem is, conky configures the default interface name upon compilation and there is no code yet to choose en0 for macOS.

Would you be willing to implement this?

npyl commented 6 years ago

I have narrowed down the file responsible for setting the default net interface: ConkyBuildOptions. Just adding a check like if(OS_LINUX) .... will do the job.

(Plus, applying the change I told you in the previous post.)

(I may check it out myself later today or tomorrow)

npyl commented 6 years ago

Hi! That's awesome thanks! With the XDamage config we can get rid of the Patches section of the wiki. Would you like to reapply it so I can merge?

npyl commented 6 years ago

That's awesome thanks!