ConnectCorp / nexmo-client

Unofficial Nexmo Rest Client
MIT License
15 stars 13 forks source link

Request parameter format issue #18

Closed apeltosa closed 8 years ago

apeltosa commented 8 years ago

When sending SMSs the request parameters are concatenated with underscore: https://github.com/ConnectCorp/nexmo-client/blob/master/src/Service/Message.php#L96

but Nexmo API says that they should be hyphenated: https://docs.nexmo.com/api-ref/sms-api/request

e.g. 'client_ref' VS 'client-ref'

Has the API changed or is this a bug?

vood commented 8 years ago

This is definitely an api change. Can you check if the underscore works for you and if not please send a PR with a fix.

apeltosa commented 8 years ago

Underscore does not work. PR done

vood commented 8 years ago

Merged