ConnectCorp / nexmo-client

Unofficial Nexmo Rest Client
MIT License
15 stars 13 forks source link

Account APIs / Lazy Loading #2

Closed CarsonF closed 9 years ago

CarsonF commented 9 years ago

P.S. Sorry for the monolithic PR. I intended to fork at first, but if you are willing to maintain this repo all the better.

CarsonF commented 9 years ago

Oh and BC has been maintained! :smile:

glennjacobs commented 9 years ago

This looks like an excellent update, only just discovered this package myself.

However, having used your fork I notice it's using "https://rest.nexmo.com/" which doesn't appear to work. Should be "https://api.nexmo.com/"

CarsonF commented 9 years ago

Thanks! I know there's a bunch of forks of the old crappy code, I was hoping to avoid that with this new one. If needed I'll think about maintaining this though.

https://rest.nexmo.com seemed to work for me and most of their documentation mentions that instead of https://api.nexmo.com. But from experience their documentation isn't completely up to date. I'll take your word for it though :)

vood commented 9 years ago

@CarsonF great job. Sorry I haven't seen the notification about the pull request. Let me code-review it first.

CarsonF commented 9 years ago

@vood No worries! Sure thing :) I made a couple changes to my fork's master branch, I'll cherry pick them to this PR.

vood commented 9 years ago

@CarsonF unfortunately we do need to have a separate base_url for each service as https://rest.nexmo.com does not support all the api features.

CarsonF commented 9 years ago

Hehe yeah I figured that out.

vood commented 9 years ago

Awesome man! Merged @CarsonF

CarsonF commented 9 years ago

Whoop! I'm going to PR a couple more things then after lunch!

vood commented 9 years ago

:+1: