Nexmo request parameter format change

ConnectCorp / nexmo-client

Unofficial Nexmo Rest Client

MIT License

15 stars 13 forks source link

Nexmo request parameter format change #22

Closed apeltosa closed 8 years ago

apeltosa commented 8 years ago

Nexmo API has changed the Request parameter formatting from underscore concatenation to hyphen concatenation. Parameter formattin changed accordingly:

When sending SMSs the request parameters are concatenated with underscore: https://github.com/ConnectCorp/nexmo-client/blob/master/src/Service/Message.php#L96

but Nexmo API says that they should be hyphenated: https://docs.nexmo.com/api-ref/sms-api/request

vood commented 8 years ago

@apeltosa great work! :+1: Could you please address the CI issues so I can merge it? Thanks.

apeltosa commented 8 years ago

@vood CI tests updated and issue solved