ConnectSDK / Connect-SDK-Android-API-Sampler

Creative Commons Zero v1.0 Universal
24 stars 21 forks source link

Incorrect UI state after failed connection. #12

Open oleksii-frolov opened 9 years ago

oleksii-frolov commented 9 years ago

When connection is failed the upper right button is shown like application is connected, if user change tabs and returns to media tab all buttons (photo, video, audio) are enabled, but of course they don't work because there is no active connection.

khk624 commented 9 years ago

The commit looks okay, but I could not reproduce this issues. How did you reproduce this? My step was,

  1. Open sampler
  2. Connect to Chromecast, or netcastTV
  3. Turn off Netcast or unplug the cable
  4. Wait for a minute, and then sampler shows "Device disconnected"
  5. move tabs to Web App Page
  6. move tabs back to Media Page

Result: Everything is disabled.

oleksii-frolov commented 9 years ago

I found this issue on Nexus 4 with Android 4.4.4 and older version of google play services library on it. It was com.google.android.gms-5.2.08. During connection to Chromecast device CastService threw ServiceCommandError because of older com.google,android.gms and it wasn't handled. And that could happen with any service.