search

ConnectSDK / Connect-SDK-Android-Core

Core source code for the Android Connect SDK project
Apache License 2.0
114 stars 79 forks source link

Philips DLNA fix #36

Closed se-bastiaan closed 9 years ago

se-bastiaan commented 9 years ago

While testing my Philips (aka TP Vision) television from 2011, I found out that the baseUrl was not ending with a /. I'm not sure where the issue comes from exactly, but this fixes it.

There is probably a better place (when discovered?) to check this, but I wasn't sure where exactly.

oleksii-frolov commented 9 years ago

Hi @se-bastiaan You should merge your changes to dev branch but not to master.

eunikolsky commented 9 years ago

@se-bastiaan, could you please also post the device description XML from the TV so that we could add tests for that case? Or you could write tests if you'd like to.

se-bastiaan commented 9 years ago

@frolov-alexey >.<

@eunikolsky Yep. I'll see if I have some time.

You sure that there is no better place to do this check?