search

ConnectSDK / Connect-SDK-Android-Core

Core source code for the Android Connect SDK project
Apache License 2.0
116 stars 82 forks source link

Code checkin for Roboelectric Test cases specifi to Core module under Co... #4

Closed ashikachhabda closed 9 years ago

ashikachhabda commented 9 years ago

code checkin for ConnectSDK Roboelectric test cases specific for core module as part of sdk_1.4-dev.

ashikachhabda commented 9 years ago

@viveksekar Please review this pull request for Roboelectric test case specific to core module.

oleksii-frolov commented 9 years ago

Everything is OK, but I have a few notices.

  1. We don't add temporary files and folders such as test-report like in this case, please remove it from the git.
  2. Log.d doesn't work for logging in Robolectric tests and it's redundant here.
  3. wildSocket and mLocalSocket are mocked object so you should not call wildSocket.disconnect() and so on. We can just remove tearDown() in SSDPSocketTest
  4. In the SSDPSearchMsgTest testToString method contains 2 test, it should be split into 2 test methods with proper names. The same is for testParseDatagram because it violates single responsibility principle.