search

ConnectSDK / Connect-SDK-Android

Android source project for Connect SDK
Apache License 2.0
308 stars 130 forks source link

Crash: SSDP response without carriage return causes crash #155

Closed khk624 closed 10 years ago

khk624 commented 10 years ago

Response without 'carriage return' ("\r") causes crash

khk624 commented 10 years ago

This has been resolved in https://github.com/ConnectSDK/Connect-SDK-Android-Core/commit/a3b36bab403b0d524642e9d2b886a5caa9f47acd

iheart2code commented 10 years ago

By ignoring the message, are we going to be preventing certain devices from being discovered?

khk624 commented 10 years ago

That was what I have intended. Do we need to discover those devices as well? (I'm trying to reproduce this issue to find out which device was it, but cannot reproduce it anymore.)

iheart2code commented 10 years ago

We certainly don't want to exclude devices. If there is a way we can get the info we need without needing the CRLF, that would be for the best.

On Thu, Sep 18, 2014 at 10:59 AM, Hyun Kook Khang notifications@github.com wrote:

That was what I have intended. Do we need to discover those devices as well? (I'm trying to reproduce this issue to find out which device was it, but cannot reproduce it anymore.)

— Reply to this email directly or view it on GitHub https://github.com/ConnectSDK/Connect-SDK-Android/issues/155#issuecomment-56077767 .

IDEAN* – The Next Big Things*

Jeremy White · Senior Mobile Developer +1 (650) 666-5811 jeremy.white@idean.com

Idean Enterprises, Inc · 411 Kipling St, Palo Alto, CA 94301 Web http://www.idean.com/ · Twitter http://www.twitter.com/idean · Facebook http://www.facebook.com/IdeanEnterprises

khk624 commented 10 years ago

Updated it.