ConnectSDK / Connect-SDK-Cordova-Plugin

Cordova/PhoneGap plugin for Connect SDK

Apache License 2.0

69 stars 46 forks source link

make it easy to install as a plugin #3

Closed orangeetv closed 9 years ago

orangeetv commented 10 years ago

Reason for the change:

It was hard to install this plugin. Users have to modify their xcode project.

Changes:

Checked in ConnectSDK and GoogleCast framework, updated plugins.xml

Results:

Install as a normal plugin: cordova plugins add https://github.com/ConnectSDK/Connect-SDK-Cordova-Plugin.git#master That is it!

NOTE:

Please update the REAME after merging.

iheart2code commented 10 years ago

While Google does not explicitly state that GoogleCast.framework may not be distributed by third parties, it is our intention to not distribute the Google Cast framework. There is a set of terms & conditions that are accepted upon downloading, and we don't want to be perceived as trying to circumvent that.

However, there is an issue open in Google's Cast SDK issue tracker that could make a one-line install possible. https://code.google.com/p/google-cast-sdk/issues/detail?id=281

As far as I am aware, the Connect SDK project should be included, though. @jlai can you comment on this?

jlai commented 10 years ago

As Jeremy noted, we don't plan on including the GoogleCast.framework ourselves unless Google clarifies its position on third-party distribution.

I've been thinking about creating a command-line tool where you'd run something like

connectsdk-setup -p projects/myproject --cast-framework=~/Downloads/GoogleCastFramework-2.1.0-Release.zip

to automatically configure everything, which would be useful for non-Cordova projects and Android projects as well, but it's low on our priority list.