search

ConnectedHumber / Air-Quality-Web

The web interface and JSON api for the ConnectedHumber Air Quality Monitoring Project.
https://sensors.connectedhumber.org/
Mozilla Public License 2.0
9 stars 4 forks source link

Charts open with Humidity selected and display 'Error: No data...' #11

Closed BNNorman closed 5 years ago

BNNorman commented 5 years ago

When I click on a device the chart defaults to trying to display Humidity which causes an error mesage to appear since most devices don't record Humidity. Clicking on a device which does record humidity is fine,

The dialog message, should be reworded to something like "No data has been recorded for this chart tab. Try clicking on another tab".

It isn't really an error message anyway - it's more of an information thing. image

sbrl commented 5 years ago

Yep! This is because that sensor has apparently reported some humidity data in the past, which the system has picked up on. Said data probably needs cleaning out, as it's probably been assigned to the wrong device id by mistake by a previous iteration of the broker script.

bsimmo commented 5 years ago

Could it default to PM2.5 (since that's the main target at the moment, then move to Temperature, then .. if not recent data) or possibly look at most recent data and then decide ?

bsimmo commented 5 years ago

Actually this seems better now. it is defaulting to PM2.5 though with robin05 with no PM sensor it errors at start.

BNNorman commented 5 years ago

If you click on Robin05’s 1 year tab it thinks there something so I think it’s the old clean up routine that is required. I have some rubbish in my records which cause problems – just haven’t gotten around to removing it (have tested the SQL on my test machine and it worked – just looking for the bottle..)

From: Ben [mailto:notifications@github.com] Sent: 25 February 2019 15:45 To: ConnectedHumber/Air-Quality-Web Cc: Brian; Author Subject: Re: [ConnectedHumber/Air-Quality-Web] Charts open with Humidity selected and display 'Error: No data...' (#11)

Actually this seems better now. it is defaulting to PM2.5 though with robin05 with no PM sensor it errors at start.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ConnectedHumber/Air-Quality-Web/issues/11#issuecomment-467060896 , or mute the thread https://github.com/notifications/unsubscribe-auth/APHW3Xj3TBTkZdCH1wL-iMq3tOg5SXKKks5vRATegaJpZM4bF609 . https://github.com/notifications/beacon/APHW3W-8rMF5d6rzcUNFXVubrnp4U9Maks5vRATegaJpZM4bF609.gif

sbrl commented 5 years ago

@bsimmo Ah yes - I fixed a bug in which it was defaulting to the first item it found, which is humidity. It was left over from the schema update.

sbrl commented 5 years ago

@BNNorman, can we close this now?

BNNorman commented 5 years ago

Yes I think so