ConnectingEurope / eInvoicing-EN16931

Validation artefacts for the European eInvoicing standard EN 16931
Other
138 stars 54 forks source link

Wrong rule context on many of the syntax rules #156

Closed SiwMeckelborg closed 5 years ago

SiwMeckelborg commented 5 years ago

A lot of the UBL syntax rules (examples: UBL-CR-001, UBL-SR-01, UBL-SR-47) only have the ubl:Invoice as context, most of these should be valid for credit note as well I assume?

oriol commented 5 years ago

These rules exclude the nodes not in the EN from the Invoice UBL model. Should be checked whether the same nodes are to be excluded from the Credit Note or additional rules shall be created.

SiwMeckelborg commented 5 years ago

Seems the preprocessed file does not have these changes included

phax commented 5 years ago

I will update XSLT and preprocessed files now

phax commented 5 years ago

Updated through https://github.com/CenPC434/validation/commit/ca7e6630b0c80809597d1438c05b249bf3a4b44e

phax commented 5 years ago

@SiwMeckelborg please re-test

SiwMeckelborg commented 5 years ago

The rule context for the syntax rules are
<rule context="/ubl:Invoice | /ubl:CreditNote"> According to the namespace declarations it should be cn:CreditNote