ConnectingEurope / eInvoicing-EN16931

Validation artefacts for the European eInvoicing standard EN 16931
Other
139 stars 54 forks source link

Is there a bug in SVRL generation? #406

Open JoergWaltherOdette opened 3 hours ago

JoergWaltherOdette commented 3 hours ago

The ISO Schema for svrl specifies:

sources: https://github.com/esacinc/sdcct/blob/master/sdcct-core/src/main/resources/META-INF/sdcct/schema/schematron/svrl.xsd https://github.com/Schematron/schema/blob/main/svrl.rnc The xml generated by the schematron artefacts produce: i.e. documents versus document What is the correct version?
phax commented 2 hours ago

It depends on the ISO Schematron version you referring to. Details follow later....

phax commented 15 minutes ago

So, here we go:

As the latest version was published in 2010, they never updated it. See https://github.com/Schematron/schematron/blob/master/trunk/schematron/code/iso_svrl_for_xslt2.xsl#L551 for the code of the last version

So the question is: remain on the "de facto standard" Schematron XSLT and use document or built something that is correct in regards to the latest ISO standard and use documents? In my Java Schematron implementation ph-schematron I decided to stick with document until further notice (see e.g. https://github.com/phax/ph-schematron/issues/149) but it might be time to change this. My compromise will be, to emit document and documents together :)

JoergWaltherOdette commented 5 minutes ago

Hi Philip,

Thanks for the analysis and thorough answer. Your proposal sounds very reasonable to me.

Best regards / beste Grüße Jörg