Closed seank-img closed 8 years ago
@seank-img, looks like a significant chunk of work - great that you did this, thank you.
@seank-img do we need some basic object definition files for installation into /etc/awa (or /usr/share/awa)? Is this planned for a future PR? Would be good to have all the standard objects and maybe even IPSO objects available for users to use. We'd need to think how we integrate this with systemd - may need to use a /etc/awa/objects.d/
@DavidAntliff yes, I've added those objects to the config dir - for now it's probably alright as it is. Future PRs could add the IPSO objects, and appropriate system.d support. Is there anything documentation wise that I need to do?
@seank-img do the client/server daemons pick up the standard object definition files automatically? If not, you may need to document that change. Also, after a 'make install', do the object definition files get copied somewhere like /etc or /usr/share? If not, that probably needs to be done, and documented, otherwise the 'installed' version won't be usable. If there's no current automatic loading, I suggest they could be auto-loaded from /etc/awa/objects.d/.xml, or stored in /usr/share/awa/objects/.xml and the init.d script updated to load them explicitly.
retest AWS CI (erbium)
retest AWS CI (erbium)
Object definitions for the firmware, location and connectivity objects should now be loaded when the daemon starts using the
--objDefs
or-o
option.