Closed yi-liang closed 7 years ago
Updating for Python 3 is a great idea in general, however I don't think it should break Python 2, which this change will do. It might be better to consider a way to support both versions, if the roadmap doesn't specifically exclude Python 2.
Also, the Python API is used by the tools test suite, so the choice of etree
(from lxml
or from xml
) should probably be dynamic - i.e. try importing the former, fall back on the latter. An "xml abstraction layer" is useful here.
None of the commits are sign-off @yi-liang please sign them. Also can you improve the description on the PR. @DuncanFrazer