search

ConnectivityFoundry / AwaLWM2M

Awa LWM2M is an implementation of the OMA Lightweight M2M protocol in C.
BSD 3-Clause "New" or "Revised" License
102 stars 66 forks source link

Static library build for RIOT #348

Closed datachi7d closed 7 years ago

datachi7d commented 7 years ago

See https://github.com/datachi7d/RIOT/tree/awa for RIOT build:

# git clone https://github.com/datachi7d/RIOT.git --branch awa --depth 1
# cd RIOT
# make -C examples/AwaLWM2M-client/

Note: this does not use the RIOT network stack - still work to do there. I didn't have much luck with the RIOT POSIX socket implementation with network_abstraction_linux.c, so possibly network_abstraction_riot.c is needed.

FlowM2MJenkinsCI commented 7 years ago

Can someone verify this patch?

FlowM2MJenkinsCI commented 7 years ago

Can someone verify this patch?

datachi7d commented 7 years ago

retest AWS CI (libcoap)

datachi7d commented 7 years ago

retest AWS CI (libcoap)

datachi7d commented 7 years ago

retest AWS valgrind (libcoap)

boyvinall commented 7 years ago

Hi @datachi7d. Looks good thanks. Just one thing .. could you sign the commits please? I'll try to get the DCO check in the check list soon.

datachi7d commented 7 years ago

From some more experimentation it seems like using CMake to build in RIOT is a bad idea - it's not really supported at all and is rather hacky. So while these changes are valid I don't recommend using CMake for RIOT, my original idea was to use the Contiki Makefile.common, Makefile.client and Makefile.erbium to build on RIOT. I can post a pull request with the modifications required to build under RIOT using the Contiki makefiles.

boyvinall commented 7 years ago

Ok, thanks Sean. Will probably close this one then I guess. I see there are some casts in this, which presumably would still apply, but easier to take those in a separate patch.

FYI, from some discussions we've had internally, we're half-considering re-visiting the overall makefile structure. It's starting to feel like a bunch of separate makefiles for different platforms .. linux, contiki, RIOT, zephyr. As usual, we have a bunch of things ongoing, so the re-visited makefile structure hasn't had a great deal of thought yet, but I thought it worth mentioning. Would be interested to see what you come up with in re-using the contiki makefiles though.