search

Connectome-Implementation-Team / rescs_shacl_shapes

SHACL Shapes for RESCS
GNU Affero General Public License v3.0
1 stars 0 forks source link

Loosen Restrictions for Data Providers #36

Closed tobiasschweizer closed 2 years ago

tobiasschweizer commented 2 years ago

The experience over the past months has shown, that some data is not provided although from a logical point the expectation is sound.

Restrictions have to be loosened for:

sh:minCount 1 had to be removed for:

@v0idness Regarding CreativeWork:author: Are there ScholarlyArticle without any author?

v0idness commented 2 years ago

As far as I am aware and as of the current state of the data, there are no articles without author.

tobiasschweizer commented 2 years ago

As far as I am aware and as of the current state of the data, there are no articles without author.

Do we still need the removal of sh:minCount 1 for CreativeWork:author then (https://github.com/Connectome-Consortium/rescs_shacl_shapes/pull/25)?

v0idness commented 2 years ago

Added the minCount back in https://github.com/Connectome-Consortium/rescs_shacl_shapes/pull/25/commits/a3e603557bbb137f084e35f84374e8b42f208576

tobiasschweizer commented 2 years ago

Ok, thanks, I'll come up with a PR containing the changes described in https://github.com/Connectome-Consortium/rescs_shacl_shapes/issues/36#issue-1269308137. In #4, there are some changes that are even only relevant for local validation with pyshacl (blank nodes) and I have no intention to merge them ever.