search

ConnectyCube / connectycube-flutter-call-kit

A Flutter plugin for displaying call screen when the app in the background or terminated.
https://developers.connectycube.com/flutter
Apache License 2.0
55 stars 75 forks source link

CallEvent does accept callerId as dart int but later casts to Java Int #97

Closed DooMMasteR closed 5 months ago

DooMMasteR commented 1 year ago

Dart integers are 64 bit and easily exceeds the range of a Java Int. Should callerId ever be larger than a Java int the operation will Except.

DooMMasteR commented 1 year ago

I guess any Dart int should rather be a Java long not int

TatankaConCube commented 1 year ago

you are right, it makes sense while using this plugin in infrastructure different from the Connectycube but for the Connectycube we are sure that the user id can't be more than the max integer value.