ConnectyCube / connectycube-flutter-samples

Code samples for Flutter, based on ConnectyCube platform
https://developers.connectycube.com/flutter/
Apache License 2.0
85 stars 91 forks source link

Mute audio on conference video call [iOS only] not working #360

Open radyhaggag opened 5 months ago

radyhaggag commented 5 months ago

Specify the sample to which the issue belongs (use [x]): [] Conference Calls sample

Platform (use [x]) [] iOS

Describe the bug: When mute the audio on the video call [Conference] the audio still working and the other participants can listen the audio without any problems.

Steps to Reproduce:

  1. Join to conference video call
  2. Try to mute the mic on iOS

Actual result: Nothing happen the other participants listen the user

Expected behavior: Mic should be muted and no one can listen the user

TatankaConCube commented 4 months ago

I just built the app from the master branch and the described issue is absent. Could you please add more details and steps for reproducing? what device do you use? Can it be the echo or sound from other devices? Have you tried to mute all other devices and then reproduce the issue?

radyhaggag commented 4 months ago

_muteMic() { setState(() { _isMicMute = !_isMicMute; _callSession.setMicrophoneMute(_isMicMute); _callManager.muteMic(_meetingId, _isMicMute);

  final audioTrack = _callSession.localStream?.getAudioTracks().firstOrNull;

  if (audioTrack != null) {
    Helper.setMicrophoneMute(
      _isMicMute,
      audioTrack,
    );
  }

  notifyParticipantsMediaUpdated();
});

The problem occurred only on iOS and there is one mic, and when user mute the mic its not muted and the other participant still hear him.

I just built the app from the master branch and the described issue is absent. Could you please add more details and steps for reproducing? what device do you use? Can it be the echo or sound from other devices? Have you tried to mute all other devices and then reproduce the issue?

radyhaggag commented 4 months ago

@TatankaConCube Please, this is urgent bug on our app so if you have any idea tell me.

the above code is for mute the mic.

TatankaConCube commented 4 months ago

I have tested our Conference Calls sample on the iPhone XR and no problems were reproduced. The common method is used for muting microphones https://github.com/ConnectyCube/connectycube-flutter-samples/blob/master/conf_call_sample/lib/src/screens/conversation_call_screen.dart#L602

why do you use Helper?

can there be some loop in your app related to the muting mic from the CallKit and from the app?

radyhaggag commented 4 months ago

why do you use Helper?

i used it because it wasn't working before it so i added it as a second method for ensure from the mute

can there be some loop in your app related to the muting mic from the CallKit and from the app?

i don't think that because it was working with the same code before and not its not working and also it working on android

TatankaConCube commented 4 months ago

also it working on android

this callback works on iOS only

it was working with the same code before

we haven't update the WebRTC lib in our SDK for a long time and the issue can't be related to our SDK, please check what code you change before getting this issue