ConnectyCube / connectycube-reactnative-samples

Chat and Video Chat code samples for React Native, ConnectyCube
https://connectycube.com
Apache License 2.0
125 stars 111 forks source link

VideoChat Sample does not work #153

Closed ErnesII closed 3 years ago

ErnesII commented 3 years ago

I just followed this guide: https://github.com/ConnectyCube/connectycube-reactnative-samples/tree/master/RNVideoChat and I was able to run the app on two physical devices: Redmi and Samsung and I was able to make a call but the remote stream seems that is not working.

Also my first try implementing this lib was based on this guide: https://developers.connectycube.com/js/videocalling because I like to see a cleaner code but it didnt work really well with react 0.60.0. Also I had to add these lines when receiving a call: session.getUserMedia(mediaParams).then(stream => { session.accept({}); }); without these lines i could not saw any remote stream. But if i add those lines i can see in one phone the remote stream.

It seems that this lib is really well documented but maybe some parts are out of date. I would really like to implement this lib in my project but it seems unstable.

Thank you!

DaveLomber commented 3 years ago

Hi @ErnesII

The code sample https://github.com/ConnectyCube/connectycube-reactnative-samples/tree/master/RNVideoChat works just well

Could you please explain in more details what does 'but the remote stream seems that is not working.' ? We will try to help here

On the session.getUserMedia(mediaParams).then(stream => { session.accept({}); }); part - agree! Let us modify the doc and make it clearer. Thank you for mentioned this

DaveLomber commented 3 years ago

Updated documentation https://developers.connectycube.com/js/videocalling?id=accept-a-call

DaveLomber commented 3 years ago

@ErnesII let us know more regarding code sample issue