search

Connehito / cake-sentry

CakePHP plugin integration for Sentry
MIT License
34 stars 26 forks source link

#25 - Cake 4 support #28

Closed BGehrels closed 4 years ago

BGehrels commented 4 years ago

Some rough draft of cake 4 support.

I tested it and it works. It should probably be a new Major release, because it requires another major version of CakePHP.

I did not quite understand the Intent of your overrides to the BaseErrorHandler. In Cake 4, the internals of it changed quite a bit (no _getMessage() exists any more, among others), so to get it working for now on my branch, i removed the overrides. Feel free to readd them, you know best what their intent was.

BGehrels commented 4 years ago

Closing this in favour of #29

o0h commented 4 years ago

@BGehrels I'm sorry for the late reply. First of all, I would like to express my deepest thanks for your great work.

The pull request #29 aiming to the same issue is opened, and it looks to be closer to the goal to me (As you said "in favour of #29"). So, can I close this pr?

BGehrels commented 4 years ago

Sure, i thought i already did :-)

o0h commented 4 years ago

Thanks!!