search

Connehito / cake-sentry

CakePHP plugin integration for Sentry
MIT License
34 stars 26 forks source link

Fix client setup #32

Closed o0h closed 4 years ago

o0h commented 4 years ago

guzzle6-adapter(via sentry/sdk) is broken. cf: https://github.com/php-http/guzzle6-adapter/commit/594cd47fb9af5c217f0e63c4e8f7602da88a368a

To avoid this problem, require php-http/guzzle6-adapter directory to use v1.1.1+ and remove sentry/sdk.

o0h commented 4 years ago

image

It works in my environment (with https://github.com/Connehito/cake-sentry/pull/26/commits/1d1e245be5b2affe0a7e0f8d97d1f7f39cd833a80)

codecov-io commented 4 years ago

Codecov Report

Merging #32 into master will decrease coverage by 1.11%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #32      +/-   ##
============================================
- Coverage     87.01%   85.89%   -1.12%     
- Complexity       25       26       +1     
============================================
  Files             5        5              
  Lines            77       78       +1     
============================================
  Hits             67       67              
- Misses           10       11       +1
Impacted Files Coverage Δ Complexity Δ
src/Http/Client.php 87.8% <0%> (-2.2%) 12% <0%> (+1%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e0a039b...912e1c0. Read the comment docs.