Closed jbbn closed 3 years ago
@Michael55555 I did everything that was mentioned on DeepSource 👍
Some notes and questions:
npm run build
runs successfully here BUT I couldn't run the application - since I used GitPod for the development 😅, which doesn't have graphics for running an Electron app)package-lock.json
changed a lot (when it should only add the new dependency (the facebook/prop-types
) - do you know how to solve that? maybe your setup or node/npm version are somehow different than mine 🤔)Hey @jbbn, thanks for the contribution, I really appreciate it! The checks don't make sure the code runs, unfortunately, we'll have to set it up later. I will check out the changes though.
For the package-lock.json
I'm not sure why it changed so much to be honest, it might be because of the setup, maybe I should try to reinstall all dependencies and upload the new file then.
My pleasure @Michael55555 🙇♂️ 🚀
Closes #18