ConnorJ88 / OOP-Assignment1

0 stars 0 forks source link

Joe Barrass 26533663 Review #2

Open JoeB2954 opened 1 year ago

JoeB2954 commented 1 year ago

Good use of comments throughout code, I understand what each segment does and how it's been implemented. Good structure to code, well thought out. Example, using deal when only one card is asked for in the multiple deal method. Shuffles are implemented efficiently. Main is fairly long, could have created more methods and called them in main rather than asking user input in main directly. Good use of testing class. Missing Card class, could be used to simplify pack creation. Excellent Error handling, all extraneous inputs or user error is handled well.

JoeB2954 commented 1 year ago

• Is the code properly documented/commented?

Good use of comments throughout code, I understand what each segment does and how it's been implemented Good structure to code, well thought out. Example, using deal when only one card is asked for in the multiple deal method. Shuffles are implemented efficiently.

• Does the code handle errors properly?

Excellent Error handling, all extraneous inputs or user error is handled well. Errors in previous reviews have been handled upon my review, I cannot find any more

• What suggestions do you have to improve the code?
Main is fairly long, could have created more methods and called them in main rather than asking user input in main directly. Good use of testing class. Missing Card class, could be used to simplify pack creation.