ConorMcPersonal / Toaster

The greatest ever Spectrum game based purely around the toast concept
Apache License 2.0
0 stars 1 forks source link

Now possible to overflow on score #31

Closed mcmenaminadrian closed 9 months ago

mcmenaminadrian commented 11 months ago

ie score more than 0x7FFF and get a negative score that way

ConorMcPersonal commented 11 months ago

That was always theoretically possible, just way too hard to achieve in reverse Polish.

Could make It a long, but that would need more real estate.

Make it a long but display it divided by 10? Or divided by 8 to allow the operation to be done via bit-shifting?

On Sat, 30 Sept 2023, 18:13 Adrian McMenamin, @.***> wrote:

ie score more than 0x7FFF and get a negative score that way

— Reply to this email directly, view it on GitHub https://github.com/ConorMcPersonal/Toaster/issues/31, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBJUJT7SITMSCWS2MTZQ4A3X5BHJ3ANCNFSM6AAAAAA5NVXRTU . You are receiving this because you are subscribed to this thread.Message ID: @.***>

mcmenaminadrian commented 11 months ago

Long >> 3 sounds like a good idea