ConorMcPersonal / Toaster

The greatest ever Spectrum game based purely around the toast concept
Apache License 2.0
0 stars 1 forks source link

Move score to a long plus other tweaks #37

Closed ConorMcPersonal closed 10 months ago

ConorMcPersonal commented 1 year ago

Score now a long, bit-shifted for display Add a new bread type (Melba) Customers in shop at the close can still be served (or leave) GameParameters and BreadBin persist throughout game Overdue refactor to simplify modifications to GameParameters and focus game.h

mcmenaminadrian commented 1 year ago

I had a chat witha friend who told me gluten free bread would be a good one to add as it takes forever to toast

On Thu, 5 Oct 2023 at 00:31, ConorMcPersonal @.***> wrote:

Score now a long, bit-shifted for display Add a new bread type (Melba) Customers in shop at the close can still be served (or leave) GameParameters and BreadBin persist throughout game Overdue refactor to simplify modifications to GameParameters and focus game.h

You can view, comment on, or merge this pull request online at:

https://github.com/ConorMcPersonal/Toaster/pull/37 Commit Summary

File Changes

(8 files https://github.com/ConorMcPersonal/Toaster/pull/37/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/ConorMcPersonal/Toaster/pull/37, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACQK2OS34WKW6DZ2HDZM53X5XWW7AVCNFSM6AAAAAA5TLY2RCVHI2DSMVQWIX3LMV43ASLTON2WKOZRHEZDOMJSGQ2TIOA . You are receiving this because your review was requested.Message ID: @.***>

ConorMcPersonal commented 1 year ago

I had a chat witha friend who told me gluten free bread would be a good one to add as it takes forever to toast

Done

mcmenaminadrian commented 1 year ago

Not identified the source for this - but: if you burn toast your score still goes up (by a lot in some cases), and the sound never recovers properly and the melba toast faster than everything, not slower!

sorry that's obviously correct for melba, getting confused with gluten, which I am yet to see

ConorMcPersonal commented 1 year ago

Bit shifting was never a sinecure, was just going to slow down how fast you could get there. Think score below zero = goodnight vienna, negative score seem to play havoc with the whole thing (which is what you're seeing too by the sound of it)

ConorMcPersonal commented 1 year ago

Gluten free is a low probability order. melba supposed to be fast. Think we need to look at scoring and reputation in general - it's currently a bit too generous all round.