search

ConorStokes / LZSSE

LZ77/LZSS designed for SSE based decompression
BSD 2-Clause "Simplified" License
134 stars 16 forks source link

Compilation fails on Linux with GCC #10

Closed da2r-20 closed 5 years ago

da2r-20 commented 5 years ago

It seems like #include <string.h> Is missing in main.cpp and lzsse*.cpp

ConorStokes commented 5 years ago

What version of gcc/distro? It's building for me on gcc (7 and 8) on ubuntu. I can add the include, but it should be redundant with memory.h included.

ConorStokes commented 5 years ago

Also, are you using the gmake premake target? Or something else?

ConorStokes commented 5 years ago

I've changed the memory.h includes to string.h, which hasn't impacted any of my build tests - so I've pushed the change. Let me know if it fixes your issue (but also, still let me know gcc version etc for future reference).

nemequ commented 5 years ago

FWIW, I'd be willing to add support for Travis CI (to test various versions of GCC and clang, and maybe PGI) to this repo, but it hardly seems worth it considering the amount of activity this repo sees…

da2r-20 commented 5 years ago

I'm using GCC 5.4.0 Ubuntu 16 And yes, I compiled using the generated gmake produced by premake

On Wed, 24 Oct 2018, 13:02 Conor Stokes, notifications@github.com wrote:

Also, are you using the gmake premake target? Or something else?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ConorStokes/LZSSE/issues/10#issuecomment-432594866, or mute the thread https://github.com/notifications/unsubscribe-auth/AGk-lfW5apXwTjK4wL6U0Uzn9f4FiHDoks5uoDqegaJpZM4X3fp0 .

ConorStokes commented 5 years ago

If you wanted to do that, I'd be happy to take the patch.

FWIW, I'd be willing to add support for Travis CI (to test various versions of GCC and clang, and maybe PGI) to this repo, but it hardly seems worth it considering the amount of activity this repo sees…

ConorStokes commented 5 years ago

I used gcc 5 (albeit on Ubuntu 18) and couldn't reproduce. Does the latest commit fix the issue for you?

I'm using GCC 5.4.0 Ubuntu 16 And yes, I compiled using the generated gmake produced by premake

da2r-20 commented 5 years ago

Yes, it did! Thank you

On Thu, 25 Oct 2018, 09:05 Conor Stokes, notifications@github.com wrote:

I used gcc 5 (albeit on Ubuntu 18) and couldn't reproduce. Does the latest commit fix the issue?

I'm using GCC 5.4.0 Ubuntu 16 And yes, I compiled using the generated gmake produced by premake

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ConorStokes/LZSSE/issues/10#issuecomment-432925866, or mute the thread https://github.com/notifications/unsubscribe-auth/AGk-lUXQLYItnkUiMyIQZ64XxmH_hOXLks5uoVTDgaJpZM4X3fp0 .