search

ConorStokes / LZSSE

LZ77/LZSS designed for SSE based decompression
BSD 2-Clause "Simplified" License
135 stars 16 forks source link

Include stddef.h for ptrdiff_t #4

Closed nemequ closed 8 years ago

nemequ commented 8 years ago

Without this I get errors about ptrdiff_t being undefined.

ConorStokes commented 8 years ago

Out of curiosity, which compiler/standard library gave you this error? Definitely can see why it happened, although most implementations pull it in through the other headers.

nemequ commented 8 years ago

GCC 5.3.1 / glibc 2.22 (on Fedora 23 x86_64).

ConorStokes commented 8 years ago

Thanks, should be merged. Will watch out for that in future.

ConorStokes commented 8 years ago

Also, just be aware gcc currently lags Visual Studio and Clang performance wise for the decompression code by over 10%. It is on my to do list to work out what is causing it.

nemequ commented 8 years ago

Thanks for the warning, but I'm just putting together a plugin for Squash (it should pop up in the new squash-plugins-extra repository soon), not for personal use (ARM compatibility is required for pretty much all my use cases, so unfortunately I can't even consider LZSSSE as-is). I can't really control which compiler people want to use (it's tested with GCC, clang, MSVC, and ICC).

Just to give you fair warning: LZSSE will probably be included in the next version of the Squash Benchmark, where it will be compiled with GCC.

Edit: realized the old version might sound a bit snarky, which really wasn't my intention, so I rewrote the first paragraph.