search

ConradIrwin / pry-rescue

Start a pry session whenever something goes wrong.
MIT License
852 stars 49 forks source link

Fix REPL not opening for rake tasks. Closes #74 #108

Closed abaldwin88 closed 6 years ago

abaldwin88 commented 6 years ago

This gem was not opening a REPL when running rake tasks. Here's a minimal rails 5 repo that reproduces the issue:

https://github.com/abaldwin88/pry-rescue-bug

abaldwin88 commented 6 years ago

Build failure does not appear to pertain to the changes in this PR. I ran a build using the current head commit from ConradIrwin/pry-rescue (6c157b1). Received the same failure message.

https://travis-ci.org/abaldwin88/pry-rescue/builds/369744599

Also I am not seeing this failure locally. Using rbenv instead of rvm. 

➤ ruby --version 
ruby 2.6.0dev (2018-04-22 trunk 63238) [x86_64-darwin15]
 ➤ rbenv --version 
rbenv 1.1.0
➤ bundle --version
Bundler version 1.16.1
ConradIrwin commented 6 years ago

thanks @abaldwin88 !

abaldwin88 commented 6 years ago

@ConradIrwin Thank you for the great gem!