ConradIrwin / vim-bracketed-paste

Handles bracketed-paste-mode in vim (aka. automatic `:set paste`)
MIT License
480 stars 28 forks source link

Use of <f28> and <f29> seems fragile #38

Open von opened 4 years ago

von commented 4 years ago

Recently, another plugin I use started setting <f29>. This broke the use of pastetoggle in vim-bracketed-paste leaving me in paste mode after my first paste. (The most obvious symptom of this being "<F28>" appearing as a prefix to all subsequent pastes.)

It seems to be that <f28> and <f29> are just being used as variables by vim-bracketed-paste and to work around the issue above, I removed their usage with apparent success.

Before I PR this change, is there some subtly of <f28> and <f29> usage that I'm missing?

ConradIrwin commented 4 years ago

I believe this plugin should be unnecessary with modern vim, as vim 8 now has support for bracketed paste — that said, I still haven't tweaked my vim config to take advantage of that; so happy for you to make whatever changes fix your problem,

P.S. Superhuman is hiring — referral bonus for Full Stack Engineers ( https://superhuman.com/roles?gh_jid=260350 ) : $1,947.

On Mon, Dec 23, 2019 at 1:19 PM, Von Welch < notifications@github.com > wrote:

Recently, another plugin I use started setting ( https://github.com/tpope/vim-rsi/commit/ad8ba6beae8e82339479104b914214a868c9f1fe#diff-e41823e91c3b6b58c3c39b8ff44aa9ee ). This broke the use of pastetoggle in vim-bracketed-paste leaving me in paste mode after my first paste. (The most obvious symptom of this being "

" appearing as a prefix to all subsequent pastes.) It seems to be that and are just being used as variables by vim-bracketed-paste and to work around the issue above, I removed their usage ( https://github.com/von-forks/vim-bracketed-paste/commit/24a8e4db3d3a54e7eadc9940d2bf81c2a4b36673#diff-44e9a3e5a7bb234b021836cc7fea54f3 ) with apparent success. Before I PR this change, is there some subtly of and usage that I'm missing? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub ( https://github.com/ConradIrwin/vim-bracketed-paste/issues/38?email_source=notifications&email_token=AAAXAQEGGQ2LPW6ETTVE76TQ2C3H3A5CNFSM4J6UCJZKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4ICKPJLQ ) , or unsubscribe ( https://github.com/notifications/unsubscribe-auth/AAAXAQGQVWBGLYMHZQ2DZLLQ2C3H3ANCNFSM4J6UCJZA ).
von commented 4 years ago

Pardon me for wandering a bit off topic here, but do you have a pointer as to how VIm 8 supports bracketed text? I've heard it does as well, but I have not been able to find any relevant documentation and playing around with Vim 8, I can't seem to make it work as I'd like (i.e. if I paste code with indentations, they just build up)

antoineco commented 3 years ago

@von better late than never 😄 I stumbled upon your question while wondering the exact same thing, and the answer is in

:help xterm-bracketed-paste

Linking the web version for convenience: https://vimhelp.org/term.txt.html#xterm-bracketed-paste