ConradLew / pe

0 stars 0 forks source link

Existence of command after execution #8

Open ConradLew opened 1 year ago

ConradLew commented 1 year ago

image.png

From the image, the DeleteCommand lifeline seems to continue even after the execution. In the worst case, readers may be confused if the same command is reused after execution.

soc-se-bot commented 1 year ago

Team's Response

Screenshot 2022-11-13 at 12.24.56 PM.png

The textbook mentions that it is not important to show object deletion for languages such as Java. Hence our group took it as an optional add on to our sequence diagrams.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: image.png

While it may be true that object deletion is not that important in Java, the omission of the delete marker is not consistent across all diagrams. In the case of the diagram provided above, the ViewClassCommand seems to have a delete marker after execution which is contradictory to the other Command classes with no delete marker. A lack of standardization across diagrams (either all command classes have delete markers, or they don't) makes it hard for the reader to see what is different and what is the same and be unsure of whether some commands are specially excluded from object deletion after execution. This can hinder the reader's understanding of the Command class lifeline, especially if they are unfamiliar with the inner workings of the original AB3 project.