search

ConradSelig / cliStocksTracker

A command line utility for tracking a stock market portfolio. Primarily featuring high resolution braille graphs.
Apache License 2.0
55 stars 14 forks source link

Added manual color selection #25

Closed yonMaor closed 3 years ago

yonMaor commented 3 years ago

Feature includes: Manual color selection to the portfolio.ini file (added instructions in the readme). This is either from the approved list, or using Hex code (which gives the used complete freedom with the color, as you mentioned). Color selection when actually drawing the graph (one of the three cases for no manual color, worded manual color, and hex manual color). Input test in the Portfolio.populate function, where I check that the color entered is valid.

ConradSelig commented 3 years ago

Made a few minor changes - including the redundant list of color names (webcolors already has that list! Why hard-code it into our program?) as well as fixing a bug preventing native color names (ex. "lime") from working. This bug was due to the fact that the color was being converted to hex but NOT rgb (the format plottile is actually looking for).

Also ran black *.py. @yonMaor you can find details on the formatter we're using here if you are interested in running that for yourself.

Overall incredible work! Thanks for doing 99% of the job here. Let me know when you are ready for your next ticket!

ConradSelig commented 3 years ago

Reference for github: #3

yonMaor commented 3 years ago

Ah! I should've known that the list would be available elsewhere.