search

ConradSelig / cliStocksTracker

A command line utility for tracking a stock market portfolio. Primarily featuring high resolution braille graphs.
Apache License 2.0
55 stars 14 forks source link

Buying / Selling stocks at multiple prices #5

Closed ConradSelig closed 3 years ago

ConradSelig commented 3 years ago

Currently tracking a stock allows for a single "total owned" value and a single "bought at" value, meaning if multiple shares of the same stock are purchased at different prices - the user has to manually take an average of the purchase prices to get decent portfolio data.

I'm not yet best sure how to best implement this. The multiple config files are already messy enough as is, and adding a line or two for every purchase would become unmanageable quite quickly.

Adding the "help wanted" label to this ticket as I am currently taking suggestions for implementation of this feature.

ConradSelig commented 3 years ago

@yonMaor Would you like to do a little testing for me? This was a huge change and chances are pretty good I've missed an edge case... Just poke around the new feature and see if you can get the program to crash / do something unexpected.

yonMaor commented 3 years ago

@ConradSelig I'm game, but I've never done any testing so I might need some guidance here.

yonMaor commented 3 years ago

Ok, so before I start testing I think I need to undestand a little more about this feature, do you have anything specific you want tested, or should I just play around with it?

ConradSelig commented 3 years ago

@yonMaor You'll want to do a combination of black-box followed by glass-box testing to make sure to hit as many test cases as possible. Have you heard those terms before?

patrick-hovsepian commented 3 years ago

It would be great to start exploring adding unit tests to the various modules. My python experience is pretty limited so I'm not aware of any frameworks offhand but I'm sure there are plenty we could leverage.

ConradSelig commented 3 years ago

I'm looking at writing a proper testing suite right now!

I want something that can integrate with github so everyone is on the same page regarding test coverage. I'll make a new ticket once I've narrowed down the options to something I like.

ConradSelig commented 3 years ago

I'm closing this ticket - testing suite should pick up any last bugs in this ticket (and this feature has been around long enough I can confidently say it is working).