[S03-Smart Contracts/M4-design-patterns/L6-general-finance] Fixes link and method name in Line #150,318

ConsenSys-Academy / Blockchain-Developer-Bootcamp

Open-source version of ConsenSys Academy's Blockchain Developer Bootcamp

Other

571 stars 423 forks source link

[S03-Smart Contracts/M4-design-patterns/L6-general-finance] Fixes link and method name in Line #150,318 #148

Closed purnimaagrawal closed 3 years ago

ConsenSys-Academy commented 3 years ago

Hi @purnimaagrawal ! so glad you're doing a PR, really enjoyed your engagement with the course on Discord and during live sessions.

If I'm reading it correctly (and please let me know if I'm not!) this is actually not a typo but references how submitTransaction calls addTransaction internally and passes it along for confirmTransaction to use.

Please see image below: Screen Shot 2021-09-27 at 2 53 32 PM

Let me know if I'm missing something!

purnimaagrawal commented 3 years ago

I thought it would make more sense to say that transactionId returned by addTransaction will be handed over to the confirmTransaction function . I think its just different way of saying . Thank you . Also, github link still needs to be fixed for this page . @ConsenSys-Academy

ConsenSys-Academy commented 3 years ago

Understood! Makes sense, thanks @purnimaagrawal