ConsenSys-Academy / Blockchain-Developer-Bootcamp

Open-source version of ConsenSys Academy's Blockchain Developer Bootcamp
Other
569 stars 423 forks source link

FIX missing RPC informative url #196

Closed lambo4jos closed 2 years ago

lambo4jos commented 2 years ago

the {target=_blank} command is used in reference to remote procedure call infering that a link to a descriptive resource of RPC should be included. the current state of the document does not include a link, therefore I added a wikipedia link to RPC for reference

ConsenSys-Academy commented 2 years ago

Same with the formatting here! (text)[link]{target=_blank} Would you mind correcting?

lambo4jos commented 2 years ago

Thanks for spotting that Coogan, should be fixed now!

ConsenSys-Academy commented 2 years ago

Ah! I think it's still a bit off -- needs to be text in parenthesis and link in brackets!

(Here is the text)[https://here-is-the-link.com]

lambo4jos commented 2 years ago

Ah! I think it's still a bit off -- needs to be text in parenthesis and link in brackets!

(Here is the text)[https://here-is-the-link.com]

Hmm... that is so weird! it doesn't appear to be working when looking at the preview option through github nor on the actual link to the markdown document on github. But not just for the link I tried fixing, for all the other links present that I didn't modify too! I just checked the markdown docs here for links https://www.w3schools.io/file/markdown-links/

the formatting they say is this: [linktext] (linkurl) -> but without the space. when I delete the space it renders a link!

which is what I was doing, and what whoever edited before me was doing for all the other links.

At the bottom of the w3c markdown documentation page it says this: "There is no way to open new window with standard markdown syntax.

You can use simple anchor tag like this below

a href="url" target="_blank">link</a Some implementations like kramdown to use below syntax link{:target="_blank"}"

I tried using the suggested tag and for some reason it doesn't appear to work either on github.

I wonder if the Consensys course website is using a different markdown render engine than the one github is using?

Please advise, as I'd like to help anyway I can to get this matter solved! Thanks for pointing this out Coogan!

ConsenSys-Academy commented 2 years ago

Awesome! All looks good!