ConsenSys-Academy / Blockchain-Developer-Bootcamp

Open-source version of ConsenSys Academy's Blockchain Developer Bootcamp
Other
569 stars 423 forks source link

Added study guides #314

Closed adilmezghouti closed 1 year ago

lonasozo commented 1 year ago

This is an awesome work! I could start work to Italian translations too 😁 I make some suggestions:

adilmezghouti commented 1 year ago

@lonasozo Thanks. I agree with you. We can even move those images to a location so that all future translations can use the same images. Regarding the English ones, we might need to run that by @ConsenSys-Academy to see if there is value in converting them to markdown.

lonasozo commented 1 year ago

Clear! About images if the assets will not change based on language, yes, one directory will be perfect 😁 Just another thing, maybe for the languages paths it's better to use more standards way to identify them, like: English -> en French -> fr Italian -> it ...and so on, just personal opinion 🙏

ConsenSys-Academy commented 1 year ago

@adilmezghouti @lonasozo Hey friends! This conversation is awesome. @lonasozo If you wanted to convert the English to markdown, that would be awesome. We need to do this anyway.

@adilmezghouti Would you be able to be separate the English and French exercises into two different branches and do another PR with just the English and another with just the French?

Really appreciate all this work, yall!

lonasozo commented 1 year ago

@ConsenSys-Academy sure I can, @adilmezghouti let me know, if you are already working on that for me it's not a problem 😉

adilmezghouti commented 1 year ago

@ConsenSys-Academy No problem. I am on it.

adilmezghouti commented 1 year ago

@ConsenSys-Academy I just updated this PR to only contain the English style guides. I will submit another PR with the French version.

lonasozo commented 1 year ago

@adilmezghouti I think could be better if you rename this Pull Request based on the new updates. Haven't got time to check new files, let me know if you are able to connect english docx to markdowns 🚀

adilmezghouti commented 1 year ago

@lonasozo Thanks for the feedback. I fixed the title and converted docx to markdown. cc @ConsenSys-Academy

ConsenSys-Academy commented 1 year ago

@adilmezghouti Thank you so much for all this!