search

ConsenSys-Academy / basic-training

Open-source repo for ConsenSys Academy's Basic Training: a software fundamentals course covering Unix-like OSes, CLI, Git, Javascript and more
https://courses.consensys.net/courses/bootcamp-basic-training
89 stars 99 forks source link

added 'check date note' below 'stack overflow' section in M1, L2 markup. #35

Closed paps-dot-dev closed 3 years ago

paps-dot-dev commented 3 years ago

I added an explanation of checking dates and main libraries. It can be found just after the 'stack overflow' section on M1, L2 index.html Screen Shot 2021-06-20 at 3 35 38 PM Screen Shot 2021-06-20 at 3 37 32 PM

paps-dot-dev commented 3 years ago

I apologize if I made a mistake here pulling this repo. First time using git and I had messed up my file paths. I noticed some of the files were removed. I can resubmit new request with all files if need be.

ConsenSys-Academy commented 3 years ago

Hey @spapineau54 ! Thank you so much for this contribution, it's great. And congratulations on contributing for your first time!

One thing, though, I believe you deleted all the other files in the course. I imagine this is a misunderstanding -- you can simply fork the repo, add in your section, do git commit and then do a Pull Request (PR) -- Git will only merge in your changes. Here is a resource you may find helpful that explains how to do a PR against a repo you've forked.

Does this make sense?

It might be cleaner for us to close this PR and have you do another one, rather than try to fix the commit. The reason is that Git will save all the changes that have ever been made for the project, including changes made on a branch that we then merge into the code, like yours. It's not great practice to have such a significant delete and un-delete process as part of the history of the codebase.

What do you think? Happy to help walk you through anything that's challenging.

paps-dot-dev commented 3 years ago

@ConsenSys-Academy think that sounds like a great idea. I have gotten some practice with git since I sent this pull so I should be able to do it correctly this time.

And thank you so much for being so helpful and welcoming to new devs like myself! It is very encouraging, and I'd really like to make this a full time career.