ConsenSysMesh / Stow-Smart-Contracts

Formerly Linnia-Smart-Contracts
https://stow-protocol.com/
MIT License
56 stars 39 forks source link

Lp 587 uploading data migration #110

Closed anujshah108 closed 5 years ago

anujshah108 commented 5 years ago

By running npm run migrate we deploy contracts and then setup the data.

This is done not in the deploy script itself because the loop would always break when called from the function was called from the deploy script.

Migrating and then running function separately is way to go.

Note you will need a .env file that I can send

codecov-io commented 5 years ago

Codecov Report

Merging #110 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #110   +/-   ##
======================================
  Coverage    96.6%   96.6%           
======================================
  Files           8       8           
  Lines         206     206           
  Branches       48      48           
======================================
  Hits          199     199           
  Misses          7       7

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9f2b1a5...7120386. Read the comment docs.

godfreyhobbs commented 5 years ago

@anujshah108 before you merge can you make sure that this is actually deploying the correct version of the smart contracts. It looks like it is deploying what has been published to NPM not the local copy of the smart contracts.