search

ConsenSysMesh / Stow-Smart-Contracts

Formerly Linnia-Smart-Contracts
https://stow-protocol.com/
MIT License
56 stars 39 forks source link

attestator signature should cover metadata #25

Closed libertylocked closed 6 years ago

libertylocked commented 6 years ago

root hash is sha(sha(metadata), sha(data))

codecov-io commented 6 years ago

Codecov Report

Merging #25 into master will increase coverage by 0.16%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
+ Coverage   96.33%   96.49%   +0.16%     
==========================================
  Files           4        4              
  Lines         109      114       +5     
  Branches       22       24       +2     
==========================================
+ Hits          105      110       +5     
  Misses          4        4
Impacted Files Coverage Δ
contracts/LinniaUsers.sol 94.73% <100%> (ø) :arrow_up:
contracts/LinniaHub.sol 94.11% <100%> (ø) :arrow_up:
contracts/LinniaRecords.sol 98.24% <100%> (+0.09%) :arrow_up:
contracts/LinniaPermissions.sol 95.23% <100%> (+0.5%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2855d3d...9ead444. Read the comment docs.

godfreyhobbs commented 6 years ago

Started reviewing, but it is a very large PR. Please consider making smaller PRs in the future. Also having more focused PRs is helpful for the reviewer. For instance, updating packages should have been a separate PR. Making these combined PR's makes it harder to have a deep thoughtful focused discussion about the code.