search

ConsenSysMesh / Stow-Smart-Contracts

Formerly Linnia-Smart-Contracts
https://stow-protocol.com/
MIT License
56 stars 39 forks source link

Solc warnings #28

Closed godfreyhobbs closed 6 years ago

godfreyhobbs commented 6 years ago

Missing abi.encodePacked is causing the following warnings.


bytes32 prefixedHash = keccak256(prefix, message);
                       ^------------------------^contracts/LinniaRecords.sol:255:8: Warning: This function only accepts a single "bytes" argument. Please use "abi.encodePacked(...)" or a similar function to encode the data.
return keccak256(dataHash, records[dataHash].metadataHash);
       ^-------------------------------------------------^
contracts/LinniaRecords.sol:283:24: Warning: This function only accepts a single "bytes" argument. Please use "abi.encodePacked(...)" or a similar function to encode the data.
bytes32 metadataHash = keccak256(metadata);
                       ^-----------------^
contracts/LinniaRecords.sol:283:24: Warning: The provided argument of type string memory is not implicitly convertible to expected type bytes memory.
bytes32 metadataHash = keccak256(metadata);
                       ^-----------------^
libertylocked commented 6 years ago

not reproducible in solidity 0.4.23

satoshi101 commented 6 years ago

This is "true warning". I had to use it while playing for this comment.