Closed godfreyhobbs closed 6 years ago
Merging #41 into master will increase coverage by
0.03%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #41 +/- ##
==========================================
+ Coverage 96.49% 96.52% +0.03%
==========================================
Files 4 4
Lines 114 115 +1
Branches 24 25 +1
==========================================
+ Hits 110 111 +1
Misses 4 4
Impacted Files | Coverage Δ | |
---|---|---|
contracts/LinniaPermissions.sol | 95.23% <100%> (ø) |
:arrow_up: |
contracts/LinniaRecords.sol | 98.27% <100%> (+0.03%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update bc9c9c3...a206bef. Read the comment docs.
what is the URI schema?
How are the data URIs computed? How are they resolved? For instance, what makes an IPFS URI different than an HTTP URI? What are the other possible protocols? Why string
not bytes
? Will this break IPFS URIs? Currently the URI are IPFS paths which is exactly 32 bytes, but aren't printable ASCII. If they are stored in string
, they will be stored in 2 words.
assertRevert does not catch out of gas.
If the test runs out of gas they should fail. assertRevert ensures this failure. expectThrow is too broad.
Fixes #40
…luding popular cloud based data Uris