Closed godfreyhobbs closed 6 years ago
Hub functions are only callable by owner, so there's no need to pause them. Maybe add pausable to other contracts, like users (register), records (upload, attest, etc), permissions (share)
I'm not sure if it's necessary to replace expect throw with assert revert. It may be a nice to have thing. Maybe in another PR?
Will update other contracts in follow-up PR.
I am going to merge
this blocked
PR in the morning, as I feel that I have addressed all requested changes
and this is a pretty simple PR and it is now blocking other work.
The abi.encodePacked
is actually part of the already approved PR #29 to 0.4.24. It only ended up here as the other PR took 11 days to get approval
Unfortunately I did not see that you are packing a single argument. The correct way is to covert it to bytes
Codecov Report
98.27% <100%> (ø)
94.73% <100%> (ø)
95.23% <100%> (ø)
Continue to review full report at Codecov.