Add pause test for every pasuable function

[libertylocked]

• no records can be added or attested when records contract is paused
• whenNotPaused tests moved to affected methods in tests

[codecov-io]

Codecov Report

Merging #47 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #47   +/-   ##
=======================================
  Coverage   96.52%   96.52%           
=======================================
  Files           4        4           
  Lines         115      115           
  Branches       25       25           
=======================================
  Hits          111      111           
  Misses          4        4

Impacted Files	Coverage Δ
contracts/LinniaRecords.sol	98.27% <ø> (ø)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dcf656a...9f9586f. Read the comment docs.

[libertylocked]

fixes #51 maybe

[MaxBlaushild]

Do we get any new functionality here? Or do we fix any bug?

[libertylocked]

Better coverage

On Fri, Jun 15, 2018, 10:49 AM Max Blaushild notifications@github.com wrote:

Do we get any new functionality here? Or do we fix any bug?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ConsenSys/Linnia-Smart-Contracts/pull/47#issuecomment-397645808, or mute the thread https://github.com/notifications/unsubscribe-auth/ABXBggQ3xfEfu5tZhjCleJ1WCwcPU_NAks5t88lggaJpZM4Uo-0S .

[godfreyhobbs]

consider leaving whenNotPaused where is already exists.

Adding whenNotPaused to the internal method is not a problem. But I do not like removing whenNotPaused from the external/public methods. I would rather have the whenNotPaused as part of the public/external function signature. This is a way of self-documenting the code.

[godfreyhobbs]

Also do you know why test coverge has not increased? Coverage 96.52% 96.52%

[libertylocked]

line coverage doesn't change branch coverage ↑

[godfreyhobbs]

The branch coverage is unchanged at 25

Branches 25 25

Does our coverage tool not work?