search

ConsenSysMesh / Stow-Smart-Contracts

Formerly Linnia-Smart-Contracts
https://stow-protocol.com/
MIT License
56 stars 39 forks source link

use raw bytes for data uri #49

Closed libertylocked closed 6 years ago

libertylocked commented 6 years ago

Fixes #45 i guess?

codecov-io commented 6 years ago

Codecov Report

Merging #49 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #49   +/-   ##
=======================================
  Coverage   96.52%   96.52%           
=======================================
  Files           4        4           
  Lines         115      115           
  Branches       25       25           
=======================================
  Hits          111      111           
  Misses          4        4
Impacted Files Coverage Δ
contracts/LinniaRecords.sol 98.27% <100%> (ø) :arrow_up:
contracts/LinniaPermissions.sol 95.23% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dcf656a...4ab2803. Read the comment docs.

godfreyhobbs commented 6 years ago

I do not agree with this change, strings are easier to use with web3. There is no need to convert to strings.

This change is not needed. There is no need to optimize gas or storage until we are ready to go to mainnet, then we will likely use something like CID.

libertylocked commented 6 years ago

Stuff like require(keccak256(abi.encodePacked(dataUri)) != keccak256(abi.encodePacked(""))); is clearly code smell. No optimization doesn't mean you can use anti patterns