Closed leeb2018 closed 6 years ago
Merging #61 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #61 +/- ##
=======================================
Coverage 96.52% 96.52%
=======================================
Files 4 4
Lines 115 115
Branches 25 25
=======================================
Hits 111 111
Misses 4 4
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d30e147...7448899. Read the comment docs.
@leeb2018 It does not make sense to share with a Nonuser. Consider removing the Non-user.
Good Diagram. I only don't like the text in the orange box of the permissions contract. That text is a little confusing
It can be something like the LinniaUsers can manage who have access to their data. Maybe something like LinniaUsers can grant and revoke access. The nonzero ethereum address sounds confusing too
Otherwise great job!
@godfreyhobbs Ah, I missed the "onlyUser" modifier. I will remove "Nonuser".
@vrotmanh Thank you for your feedback! It was really helpful. I have made an update accordingly.
You can check out the updated version of the diagram here. Let me know what you think! Love to hear more feedbacks.
@leeb2018 can you update the pull request with the updated diagram?
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 5 committers have signed the CLA.
:white_check_mark: godfreyhobbs
:white_check_mark: leeb2018
:x: davidrhodus
:x: libertylocked
:x: Byeongchan Lee
Issue with signing commit got out of my hand, so I have decided to close this PR and delete branch. I will create exact same branch and PR with updated diagram.
Quick update to README.md after adding the Linnia architecture diagram.