Move HTH into Records - Githubissues

ConsenSysMesh / Stow-Smart-Contracts

Formerly Linnia-Smart-Contracts

https://stow-protocol.com/

MIT License

56 stars 39 forks source link

Move HTH into Records #8

Closed libertylocked closed 6 years ago

libertylocked commented 6 years ago

Got rid of HTH contract. HTH score is part of the Record now
Updated tests
Use safemath

godfreyhobbs commented 6 years ago

@libertylocked @buendiadas @mathcrypto Is there anyway to test safe math? Can you add a test trying to set the hth score to a negative value?
Also is there any way to test for race conditions? What if two requests to increment hthscore happen at the same time? Will one of the updates be lost?

libertylocked commented 6 years ago

Safemath is audited already so we dont test it. All open zeppelin contracts are. Transactions are executed in order so there will never be race condition