adding BLS12-381 sig verification and aggregation

ConsenSysMesh / cava

ConsenSys core libraries for Java & Kotlin

Apache License 2.0

84 stars 34 forks source link

adding BLS12-381 sig verification and aggregation #137

Closed jrhea closed 5 years ago

jrhea commented 5 years ago

BLS scheme implemented as specified: https://github.com/zkcrypto/pairing/tree/master/src/bls12_381

Details:

G1 elements: g, pubkey
G2 elements: Hash(message), Signature
Signature verification: e(pk x g, Hash(message)) == e(g, pk x Hash(message))

CLAassistant commented 5 years ago

All committers have signed the CLA.

jrhea commented 5 years ago

I made a push with preliminary fixes. i am only getting to work on this in short bursts so be patient. Thanks

jrhea commented 5 years ago

~Still missing documentation for~

[x] SignatureAndPublicKey
[x] Signature
[x] PublicKey
[x] PrivateKey
[x] KeyPair ~Scalar~ ~GTPoint~ ~Group~ ~G2Point~ ~G1Point~ ~AtePairing~

atoulme commented 5 years ago

If some of those classes are made package visible only you don't need to document them.

cleishm commented 5 years ago

Yeah, that is way too wide an API for the module.

cleishm commented 5 years ago

See if you can limit it to just the classes/methods you’d expect the end user to interact with.

jrhea commented 5 years ago

ok done. I will wait for a thumbs up (or down) from you guys.

cleishm commented 5 years ago

Looks good! I added a few cleanups to take care of - happy to help out if you like.

jrhea commented 5 years ago

Dude. Would love the help. I'm still going to need to iterate on this library. Think we can do some sort of experimental release so I can experiment with it inside of Artemis?

atoulme commented 5 years ago

Every commit to master triggers a snapshot build available on jcenter.

jrhea commented 5 years ago

Every commit to master triggers a snapshot build available on jcenter.

So that's def helpful; however, a lot of this stuff is in flux. I don't want to waste everyone's documenting methods and coming up with the perfect API if it is just going to change. Now that being said, all the other suggestions you guys made were money. What do you think about making an experimental branch (or whatever you want to call it) that I can target for these types of PRs?

jrhea commented 5 years ago

ok I am pushing some fixes. Not everything is resolved, but I have to stop for now.

cleishm commented 5 years ago

Dude. Would love the help. I'm still going to need to iterate on this library. Think we can do some sort of experimental release so I can experiment with it inside of Artemis?

Yeah - of course. Once it's merged in, you'll have a snapshot to play with. And happy to chat about any changes and help do them, rather than just reviewing.