Closed jrhea closed 5 years ago
It's a "domain value", but an integer? Is there a range for this value? Or is it only certain discrete values? If the former, the range should probably be documented and asserted. If it's the later, then it should probably be an enum.
I'm experimenting with the math. There is a fundamental issue with milagro that is making it difficult...hence, my rushed changes. I wanted to use an experimental branch so that I didn't have to scrutinize every change. instead i will just modify locally and stop pushing
Is the issue access to a snapshot build for your experimental branch? I don’t see any reason why CI on this repo couldn’t be configured to push snapshots to bintray for an arbitrary branch, or perhaps even for all PR builds? Then you could experiment to your hearts content, and still get builds to try. The catch, of course, is how and when to conclude experiments and wrap them in. Cava modules, as a general toolkit, should of course be reasonably polished when they are published in release builds.
Is the issue access to a snapshot build for your experimental branch? I don’t see any reason why CI on this repo couldn’t be configured to push snapshots to bintray for an arbitrary branch, or perhaps even for all PR builds? Then you could experiment to your hearts content, and still get builds to try. The catch, of course, is how and when to conclude experiments and wrap them in. Cava modules, as a general toolkit, should of course be reasonably polished when they are published in release builds.
Totally agree that things should be polished. That being said, I don't want to waste time polishing a 💩.
Right. Hence an experiments branch? Although I guess you could also just do a gradle install
and have it available locally anyway 🤷♀️
Just needed the domain param exposed.