Add SSZ Encoding Support for java.util.List of Bytes

ConsenSysMesh / cava

ConsenSys core libraries for Java & Kotlin

Apache License 2.0

84 stars 34 forks source link

Add SSZ Encoding Support for java.util.List of Bytes #152

Closed schroedingerscode closed 5 years ago

schroedingerscode commented 5 years ago

Adds SSZ encoding support for java.util.List of Bytes in addition to varags list of Bytes, which is already supported. Corresponding tests are also added.

If desired, I can open an issue to encode java.util.Lists of the other types SSZWriter currently supports.

This PR resolves #142.

CLAassistant commented 5 years ago

All committers have signed the CLA.

cleishm commented 5 years ago

Rather than merging "branch 'master' into feat/ssz-support-for-bytes-list", rebase the changes onto master?

schroedingerscode commented 5 years ago

Sounds good, I'll rebase my changes on top of current master and squash my 2 commits as well as the comment fixes.

cleishm commented 5 years ago

If desired, I can open an issue to encode java.util.Lists of the other types SSZWriter currently supports.

For consistency in the API, it would be good to support all "list" encoders accepting either an array/varargs, or a list collection.

schroedingerscode commented 5 years ago

Ready for Review

java.util.List support has been added for other SSZWriter supported types.

cleishm commented 5 years ago

Wow. Nice.