Give SSZ#merkleHash Public Visibility for Compatibility

ConsenSysMesh / cava

ConsenSys core libraries for Java & Kotlin

Apache License 2.0

84 stars 34 forks source link

Give SSZ#merkleHash Public Visibility for Compatibility #198

Closed schroedingerscode closed 5 years ago

schroedingerscode commented 5 years ago

This PR modifies the visibility of SSZ#merkleHash to be public, which allows compatibility and ease of implementation with some versions of the Eth2 Beacon Chain spec. More details are provided in the linked issue.

Resolves #197

cleishm commented 5 years ago

If it's exposed publicly, it's worth adding more error checking to the method itself. E.g. validate the argument is not null, and probably check that all list elements are of the same size.

schroedingerscode commented 5 years ago

Makes sense, I'll look through it once more and add some sensible error checks.

atoulme commented 5 years ago

Going to close this for now. Please reopen if you would like to see this come through.