ConsenSysMesh / cava

ConsenSys core libraries for Java & Kotlin
Apache License 2.0
84 stars 34 forks source link

Consistently wrap fingerprint map in unmodifiable #41

Closed cleishm closed 6 years ago

cleishm commented 6 years ago

This PR simply ensures the fingerprint map is always wrapped inunmodifiableMap. This is actually unnecessary, as the map and all accesses to it are private to the class, where it can be trivially observed that writes to it are not occurring. Also, the tests confirm this.

However, adding it helps readability, and the overhead is minimal.